Cleanup Ember dependencies #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgrif @carols10cents it appears that the build is failing due to unrelated reasons ( |
|
@Turbo87 sorry about that, we added caching to travis. It should be fixed now, could you try rebasing on master please? |
"ember-cli-moment-shim" takes care of that for us automatically
This is already imported by ember-cli-qunit
|
@carols10cents no problem. rebased, let's try again :) |
carols10cents
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and cleans up some of the npm and bower dependencies of the Ember app in this repository.
Most notable:
ember-sourcefrom npm instead ofemberfrom bowerlodashdependency with a 5 line function/cc @locks